Bug #971
jmod.sur.input~ do not store filename as parameter
| Status: | Closed | Start date: | 2011-10-13 | |
|---|---|---|---|---|
| Priority: | Normal | Due date: | ||
| Assignee: |  Trond Lossius |
% Done: | 100% |
|
| Category: | - | Spent time: | - | |
| Target version: | - | |||
| Branch: | OS: |
Description
As such the interface of this module is inconsistent with jmod.input~. We should decide on a common approach, and make sure that all file-playing modules (be that midi, video or sound) behave the same.
My vote would go towards including it in the file playing modules (as that is where the file playing actually takes place) rather than in separate file selector modules (which could rather store e.g. what folder to list the files of in a pop-up menu).
Associated revisions
closes #971
History
Updated by Nils Peters 7 months ago
that's easy to change.
One thing, in jmod.input~, the play message (/soundfile/play) is a parameter. IMHO, this should be a message. What do you think ?
Updated by Pascal Baltazar 7 months ago
my opinion is that they should both be parameters, so they can be stored/recalled with cueManager... but that's maybe a very personal way of doing things...
Updated by Trond Lossius 7 months ago
I fully agree with Pascal here. It makes it much easier to get the play thing included in cues when it is a parameter, and shows up when the state is queried.
Updated by Nils Peters 3 months ago
- Status changed from New to Closed
- % Done changed from 0 to 100
Applied in changeset 773e9833a747f3d5b56ff229e2c65ec1c20637a0.