Feature Request #807

sample rate of the jcom.in/out embedded amplitude follower

Added by Pascal Baltazar almost 6 years ago. Updated about 4 years ago.

Status:RejectedStart date:2011-07-02
Priority:NormalDue date:
Assignee:Théo de la Hogue% Done:

0%

Category:-Spent time:-
Target version:MVC for 0.6
Branch:

Description

there currently is an embedded amplitude follower (or maybe measurement) in jcom.in and jcom.out. Very good !

Though, there is no way to turn it off, or to change its samplerate.

Théo proposes that setting its samplerate to 0 stops the measurement. That sounds like a good idea.

The remaining question is : how do we address it ?
I propose that we add a parameter :
/in/amplitude/active @type boolean

CrashLogTrond.txt Magnifier (64.3 KB) Pascal Baltazar, 2012-08-02 03:41 pm


Related issues

Copied to Max - Feature Request #1492: sample rate of the jcom.in/out embedded amplitude follower Closed 2011-07-02

History

#1 Updated by Trond Lossius about 5 years ago

Here's a crash log that might be related:

[edit by Pascal to make the thread more readable : the crash log has been atttached as a file)

#2 Updated by Trond Lossius about 5 years ago

Would be nice to have it silenced when audio is not being processed.

#3 Updated by Théo de la Hogue about 5 years ago

just copying a hint from Tim :

"Specifically, it looks like closing the patcher and freeing the jcom.in~ at the same time that the amplitude follower in jcom.in~ is doing something in another thread. So maybe there is a thread-safety problem here...

best,
Tim"

#4 Updated by Théo de la Hogue about 5 years ago

  • Status changed from New to Resolved

it's ok now.

I add a FR for to have jcom.in~ amplitude follower silenced when audio is not being processed.

#5 Updated by Pascal Baltazar about 5 years ago

  • Status changed from Resolved to Assigned

maybe we should not mark this FR as resolved, as the initial question has not been adressed yet (AFAIK)

#6 Updated by Théo de la Hogue about 5 years ago

the commit should resolve this FR.

with this commit there is an in/amplitude/active internal parameter inside the jcom.in~.

however this is an integer parameter in order to set the sample rate of the amplitude follower so the word "active" is not the best...

maybe the FR shouldn't be closed.

#7 Updated by Théo de la Hogue about 5 years ago

I told about this commit:https://github.com/jamoma/JamomaModular/commit/8844ee6b15d9a32229a7df59c2869d8ca187b728

#8 Updated by Pascal Baltazar almost 5 years ago

great work, Théo !

as the main function is setting the samplerate, maybe this should be renamed out/amplitude/samplerate shouldn't it ?
and turning it off is just a special case of samplerate, when it is equal to 0...

what do you think ?

BTW, it's a bit strange that the model outputs out/amplitude.1 and out/amplitude.2
and the parameter doesn't take account of the fact that there are instances...

I'm not sure that it's a good idea, but maybe we could have separate samplerate for each instance (i.e. channel) ?

though, if that makes things overly complicated, maybe we can just stay as is now...

opinions ?

#10 Updated by Pascal Baltazar almost 5 years ago

As Tim stated on the devel list :

You should be able to turn it off and then back on without having to remember what it was before your turned it off.

in reply to the question below

So, the current parameter out.n/amplitude/active should be renamed out.n/amplitude/samplerate

And a new parameter out.n/amplitude/active should be added to enable/disable the amplitude following...

amplitude following can be enabled/disabled, and its samplerate can be changed by the same message :

out.n/amplitude/active (where n is the number of the output channel)

I was just wondering if this message should (or should not) be renamed

out.n/amplitude/samplerate

knowing that out.n/amplitude/samplerae 0 would disable the amplitude following

or should there be yet another parameter ?

#11 Updated by Trond Lossius about 4 years ago

  • Status changed from Assigned to Rejected

Also available in: Atom PDF