Bug #301

audio/gain is broken

Added by Nils Peters about 10 years ago. Updated about 10 years ago.

Status:ClosedStart date:2009-09-06
Priority:UrgentDue date:
Assignee:Théo de la Hogue% Done:

0%

Category:-Spent time:0.50 hour
Target version:0.5
Branch: OS:

Description

Hi,

I just made fresh builds using the 0.5-maintenance branch on my old macbook with Snow Leopard and XCode 3.2.
It seems that in all audio modules the green audio/gain dial is useless.
Not sure why this happened, but I looked into the sourcecode of jcom.out.cpp and saw this from line 132:

TTObjectInstantiate(TT, &x->xfade, x->numOutputs);
x->xfade->setAttributeValue(TT, 1.0);
//TTObjectInstantiate(TT, &x->gain, x->numOutputs);
TTObjectInstantiate(TT, &x->gain, x->numOutputs);
TTObjectInstantiate(TT, &x->ramp_gain, x->numOutputs);
TTObjectInstantiate(TT, &x->ramp_xfade, x->numOutputs);

Does that mean that we're using now a limiter, rather than a simple gain stage in every module which also screws up our gain dial?

best,
Nils

History

#1 Updated by Nils Peters about 10 years ago

  • Target version set to 0.5

#2 Updated by Nils Peters about 10 years ago

  • Assignee set to Tim Place

Hi Tim,

I did some testings. Can you tell me if that makes sense?
I changed line 132 in jcom.out.cpp

TTObjectInstantiate(TT("gain"), &x->gain, x->numOutputs);
//TTObjectInstantiate(TT("limiter"), &x->gain, x->numOutputs);

the gain stage works now again.
I am not sure for what purpose the limiter should be instantiated here....

cheers,

Nils

#3 Updated by Tim Place about 10 years ago

  • Assignee changed from Tim Place to Théo de la Hogue

I'm not sure. According to the link below, it looks like a change that was made by Théo.

http://github.com/tap/JamomaModular/blame/88ada210f649d3c3c678bc1a528b1f6b855c1478/SourceCode/MaxObjects/jcom.out/jcom.out.cpp

Théo, do you some thoughts about this?

#4 Updated by Théo de la Hogue about 10 years ago

  • Status changed from New to Closed

Sorry It was me !
I uncommented the line on a recent commit on the 0.5-maintenance.

#5 Updated by Nils Peters about 10 years ago

Hi Theo,

no problem.

Now the code looks like this:

TTObjectInstantiate(TT("gain"), &x->gain, x->numOutputs);
TTObjectInstantiate(TT("limiter"), &x->gain, x->numOutputs);
TTObjectInstantiate(TT("ramp"), &x->ramp_gain, x->numOutputs);
TTObjectInstantiate(TT("ramp"), &x->ramp_xfade, x->numOutputs);

And the gain stage is still broken :(
I need to delete the limiter line, in order to make it work.

best,

Nils

#6 Updated by Nils Peters about 10 years ago

fixed in 0.5-maintenance branch

Also available in: Atom PDF